Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chance of bad type creation in CI #53

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Fix chance of bad type creation in CI #53

merged 1 commit into from
Aug 24, 2023

Conversation

mattjala
Copy link
Collaborator

No description provided.

@mattjala mattjala added the bug Something isn't working label Aug 24, 2023
jhendersonHDF
jhendersonHDF approved these changes Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@jhendersonHDF jhendersonHDF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really do away with test_rest_vol as soon as we can. Hopefully we can get the build process with the library working smoothly. Will test again with the merged cmake updates.

@jhendersonHDF jhendersonHDF merged commit a3d6d88 into HDFGroup:master Aug 24, 2023
5 checks passed
@mattjala mattjala deleted the zero_len_str_fix branch August 31, 2023 20:46
mattjala added a commit to mattjala/vol-rest that referenced this pull request Sep 5, 2023
@mattjala
Fix chance of bad type creation in CI (HDFGroup#53)
1922bc5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendersonHDF jhendersonHDF jhendersonHDF approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattjala @jhendersonHDF